Skip to content

Conversation

mmarkows17
Copy link
Collaborator

Supporting code for the blog post Physics-Informed Machine Learning: Methods and Implementation

@@ -0,0 +1,97 @@
classdef spectralConvolution1dLayer < nnet.layer.Layer ...
Copy link
Collaborator

@bwdGitHub bwdGitHub Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect we could use the same version here and in the 1d FNO example - maybe we should consider a directory of shared tools for the examples.

That's something we'll have to look into in future I think, not something to try deal with in this PR.

Copy link
Member

@conordaly0 conordaly0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome Mae!

I still need to review the other MLX files, but I wanted to post my initial comments first.

Copy link
Member

@conordaly0 conordaly0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Mae!

Copy link
Collaborator

@bwdGitHub bwdGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be some open conversations still, but this is looking good to me.

I forget if I said elsewhere, but just in case, we should "Squash and merge" when merging this. That seems to be the default when I look, probably because we've used that elsewhere. My understanding is that will prevent those large data files, hidden in the historic commits, won't end up in the main branch since a later commit deletes them, and squashing those together will remove the files from the git history.

@mmarkows17 mmarkows17 merged commit f2497e9 into main Jul 14, 2025
@mmarkows17 mmarkows17 deleted the PhiML_blog_supporting_code branch July 14, 2025 16:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants