-
Notifications
You must be signed in to change notification settings - Fork 35
Adding supporting code for blog post #9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@@ -0,0 +1,97 @@ | |||
classdef spectralConvolution1dLayer < nnet.layer.Layer ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect we could use the same version here and in the 1d FNO example - maybe we should consider a directory of shared tools for the examples.
That's something we'll have to look into in future I think, not something to try deal with in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome Mae!
I still need to review the other MLX files, but I wanted to post my initial comments first.
phiml-blog-supporting-code/physics-informed-ml-blog-supporting-code.prj
Outdated
Show resolved
Hide resolved
…g m files and md files for each subdirectory
… add startup script
…xample so that motion remained bounded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Mae!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be some open conversations still, but this is looking good to me.
I forget if I said elsewhere, but just in case, we should "Squash and merge" when merging this. That seems to be the default when I look, probably because we've used that elsewhere. My understanding is that will prevent those large data files, hidden in the historic commits, won't end up in the main branch since a later commit deletes them, and squashing those together will remove the files from the git history.
Supporting code for the blog post Physics-Informed Machine Learning: Methods and Implementation